Add thread/resume compatibility shim to code app-server#569
Open
cbusillo wants to merge 2 commits intojust-every:mainfrom
Open
Add thread/resume compatibility shim to code app-server#569cbusillo wants to merge 2 commits intojust-every:mainfrom
cbusillo wants to merge 2 commits intojust-every:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eda8e469b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Author
|
Addressed the Codex review feedback in Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thread/resumehandler tocode-rs/app-serverThreadResumeResponseaddConversationListenerandsendUserTurnWhy
Codexia expects
thread/resumesemantics for Codex-compatible backends.code-rsalready had the lower-levelresumeConversationpath, but it did not expose the v2thread/resumerequest shape that Codexia can use directly.This change intentionally adds a compatibility shim rather than porting the full
codex-rsthread manager. The goal is to restore native-looking resume/continue behavior for clients like Codexia with the smallest viable app-server change.Validation
cargo check -p code-app-servercargo test -p code-app-server thread_resume_response_thread_uses_catalog_metadatacode-app-serverconfirmingthread/resume,addConversationListener, andsendUserTurnall succeed using the historical thread idcode app-serverbinary on PATH